feat: error on user-injected bad images #8992
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48502af5a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f41a982b03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if content | ||
| .iter() | ||
| .any(|item| matches!(item, ContentItem::InputImage { .. })) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
This logic returns false as soon as the current turn contains any user input_image, even if the invalid image that triggered InvalidImageRequest actually came from a tool output. Now that view_image emits an input_image as a function-call output, it’s possible to have both a valid user image and an invalid tool image in the same turn; in that case the error handler will misclassify the failure as “user‑injected,” emit an error event, and stop the turn instead of retrying with the tool image replaced. That’s a regression from the previous behavior where tool-originated invalid images would be recoverable.
Useful? React with 👍 / 👎.
No description provided.